dbalek commented on a change in pull request #3196:
URL: https://github.com/apache/netbeans/pull/3196#discussion_r721964283
##########
File path: java/java.lsp.server/vscode/src/testAdapter.ts
##########
@@ -52,6 +53,7 @@ export class NbTestAdapter {
async run(request: TestRunRequest, cancellation: CancellationToken):
Promise<void> {
cancellation.onCancellationRequested(() => this.cancel());
this.currentRun = this.testController.createTestRun(request);
+ this.itemsToRun = new Set();
Review comment:
This change is related to GR-31747. If there is an exception thrown form
a test suite initialization, the new VSCode explorer marks the corresponding
suite node as erroneous, however individual test nodes below the suite nodes
display the state from the tests last run. That could lead to false success
state. It is IMHO better to marked these test as 'skipped' (they were not
executed due to exception in the suite initialization).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
