JaroslavTulach commented on a change in pull request #3213:
URL: https://github.com/apache/netbeans/pull/3213#discussion_r722977400
##########
File path:
groovy/groovy.editor/src/org/netbeans/modules/groovy/editor/compiler/PerfStatCompilationUnit.java
##########
@@ -235,12 +239,37 @@ public TimingOp(Object delegate, int phase) {
if (cn.contains("$$Lambda")) { // NOI18N
StackTraceElement invokedFrom = null;
for (StackTraceElement ele : new Throwable().getStackTrace()) {
- boolean myClass =
ele.getClassName().startsWith(PerfStatCompilationUnit.class.getName());
+ boolean myClass =
ele.getClassName().startsWith("org.netbeans.modules.groovy.editor.");
if (!myClass) {
invokedFrom = ele;
break;
}
+
}
+ if (cn.contains("ASTTransformationVisitor$$Lambda$")) {
+ String k = invokedFrom.getMethodName() + ":" +
invokedFrom.getLineNumber();
Review comment:
?
##########
File path:
java/java.source.base/src/org/netbeans/modules/java/source/classpath/CacheClassPath.java
##########
@@ -81,6 +81,39 @@ private CacheClassPath (ClassPath cp, boolean translate,
boolean scan) {
}
}
+ @Override
+ public int hashCode() {
+ int hash = 7;
+ hash = 53 * hash + Objects.hashCode(this.cp);
+ hash = 53 * hash + (this.translate ? 1 : 0);
+ hash = 53 * hash + (this.scan ? 1 : 0);
+ return hash;
+ }
+
+ @Override
+ public boolean equals(Object obj) {
Review comment:
How is this related to Groovy?
##########
File path: groovy/groovy.editor/nbproject/project.xml
##########
@@ -506,6 +506,7 @@
<friend>org.netbeans.modules.groovy.grailsproject</friend>
<friend>org.netbeans.modules.groovy.gsp</friend>
<friend>org.netbeans.modules.groovy.refactoring</friend>
+ <friend>org.netbeans.modules.micronaut</friend>
Review comment:
If Micronaut has dependency on Groovy editor, then the Micronaut support
cannot be enabled without enabling Groovy. That doesn't seem desirable to me.
It certainly wasn't the case so far.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
