sdedic commented on a change in pull request #3223:
URL: https://github.com/apache/netbeans/pull/3223#discussion_r725217366
##########
File path:
platform/openide.util/src/org/netbeans/modules/openide/util/NbBundleProcessor.java
##########
@@ -378,7 +378,7 @@ private void warnUndocumented(int i, Element e, String key)
{
}
}
}
- processingEnv.getMessager().printMessage(Kind.WARNING, "Undocumented
format parameter {" + i + "}", e, mirror, value);
+ processingEnv.getMessager().printMessage(Kind.WARNING, "Undocumented
format parameter {" + i + "} prepend line: # {" + i + "} - some text,", e,
mirror, value);
Review comment:
Separate into its own commit ?
##########
File path: java/java.source/src/org/netbeans/modules/java/JavaDataObject.java
##########
@@ -90,6 +93,30 @@ protected DataObject handleCopyRename(DataFolder df, String
name, String ext) th
public static MultiViewEditorElement createMultiViewEditorElement(Lookup
context) {
return new MultiViewEditorElement(context);
}
+
+ @Override
+ protected DataObject handleCreateFromTemplate(DataFolder df, String name)
throws IOException {
+ if (name == null) {
+ return super.handleCreateFromTemplate(df, name);
+ }
+ String[] packageAndName = name.split("\\.");
+ if (packageAndName.length > 1) {
+ verifyJavaNames(packageAndName);
Review comment:
nitpick - may possibly accept `package-info` as a valid package name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
