sdedic commented on a change in pull request #3224:
URL: https://github.com/apache/netbeans/pull/3224#discussion_r725218805
##########
File path:
groovy/groovy.support/src/org/netbeans/modules/groovy/support/actions/GroovyComputeTestMethods.java
##########
@@ -95,6 +94,14 @@
return result;
}
+ private static boolean extendsSpecification(ClassNode classNode) {
+ ClassNode superClass = classNode.getSuperClass();
+ if (superClass != null) {
+ return "spock.lang.Specification".equals(superClass.getName()) ?
true : extendsSpecification(superClass);
Review comment:
Pls. add a infinite recursion guard: ClassNodes may be parsed from a
uncompilable source.
##########
File path:
ide/gsf.testrunner/src/org/netbeans/modules/gsf/testrunner/api/TestSession.java
##########
@@ -61,6 +62,10 @@
* The suites that were executed.
*/
private final List<TestSuite> testSuites = new ArrayList<TestSuite>();
+ /**
+ * Current suite indexes.
+ */
+ private final Stack<Integer> suiteIdxs = new Stack<Integer>();
Review comment:
Isn't synchronization needed on this index (i.e. TestSession being
populated & queried at the same time) ?
##########
File path:
ide/gsf.testrunner.ui/src/org/netbeans/modules/gsf/testrunner/ui/TestMethodFinderImpl.java
##########
@@ -52,7 +55,7 @@
public static final String NAME = "tests"; // NOI18N
public static final int VERSION = 1;
- public static TestMethodFinderImpl INSTANCE = null;
+ public static TestMethodFinderImpl INSTANCE = new TestMethodFinderImpl();
Review comment:
`final` ?
##########
File path: java/gradle.test/nbproject/project.xml
##########
@@ -26,46 +26,38 @@
<code-name-base>org.netbeans.modules.gradle.test</code-name-base>
<module-dependencies>
Review comment:
nitpick: if possible, consolidate the changes, it's hard to tell what
dependencies were actually updated :(
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
