mbien commented on pull request #3221:
URL: https://github.com/apache/netbeans/pull/3221#issuecomment-940199010
> > I hope that this can be integrated fairly soon since sweeping changes
tend to conflict fast.
>
> Not entirely sure on that statement - I prefer, sweeping changes at the
beginning of release cycles! Given feature freeze and VSNetBeans releases are
imminent.
>
so you are saying it isn't feature freeze yet? ;)
Problem with this kind of PRs (many trivial changes) is that if it isn't
integrated soon, it never will. You can find some cleanup PRs here which are a
year old, have been approved, were never integrated and wouldn't apply cleanly
anymore. To avoid this, you need good timing otherwise it can feel like wasted
time for those involved if they are still around (reset, new commit, repeated
review of the same task).
> On the changes here, if you're trying to remove unnecessary boxing,
wouldn't a few of these benefit from using `parse*(String ...)` rather than
`valueOf(String ...)`?
if the destination type is a primitive and the source is a String, then yes.
Should be easy to formulate a jackpot rule if there isn't one yet. If the
destination is an Object, then valueOf is ok.
If some cases have been overlooked we could just add a complementary PR.
(Sometimes you have to run a code inspection twice, since one applied rule can
trigger another.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
