entlicher commented on a change in pull request #3235:
URL: https://github.com/apache/netbeans/pull/3235#discussion_r726921051
##########
File path:
java/debugger.jpda.truffle/src/org/netbeans/modules/debugger/jpda/truffle/RemoteServices.java
##########
@@ -95,17 +95,17 @@
private static final Logger logger =
Logger.getLogger(RemoteServices.class.getName());
- static final String REMOTE_CLASSES_ZIPFILE =
"/org/netbeans/modules/debugger/jpda/truffle/resources/JPDATruffleBackend.jar";
+ static final String REMOTE_CLASSES_ZIPFILE =
"/org/netbeans/modules/debugger/jpda/truffle/resources/JPDATruffleBackend.jar";
// NOI18N
- private static final String TRUFFLE_CLASS =
"com.oracle.truffle.api.Truffle";
- private static final String EXPORT_TRUFFLE_CLASS =
"com.oracle.truffle.polyglot.LanguageCache$Loader";
- private static final String EXPORT_TRUFFLE_METHOD = "exportTruffle";
- private static final String EXPORT_TRUFFLE_SIGNAT =
"(Ljava/lang/ClassLoader;)V";
+ private static final String TRUFFLE_CLASS =
"com.oracle.truffle.api.Truffle"; // NOI18N
Review comment:
It's certainly good to test the released GraalVM and we should improve
our current tests, but GraalVM integration tests can also be extended with
NB-specific tests to catch possible issues early and assure compatibility.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
