JaroslavTulach commented on a change in pull request #3256:
URL: https://github.com/apache/netbeans/pull/3256#discussion_r732377136
##########
File path:
java/java.hints/src/org/netbeans/modules/java/hints/errors/Bundle.properties
##########
@@ -70,7 +70,7 @@ MSG_ClassesWhereImplementFound={0} subclass(es) found
MSG_Cancel=Cancel
-MSG_ChangeVariablesType=<html>Change type of {0} to {1}
+MSG_ChangeVariablesType=Change type of {0} to {1}
Review comment:
Thank you.
##########
File path:
java/java.editor/src/org/netbeans/modules/java/editor/imports/ComputeImports.java
##########
@@ -392,23 +380,7 @@ public String displayNameForImport(@NonNull Element
element) {
fqnSB.append(info.getElementUtilities().getElementName(element, true));
if (element.getKind() == ElementKind.METHOD) {
- String fqn = fqnSB.toString();
- fqnSB.append('(');
- // check if there are no overloads, otherwise append just ellipsis:
- Collection<Element> col = fqn2Methods.get(fqn);
- if (col == null || col.size() == 1) {
- boolean first = true;
- for (VariableElement var : ((ExecutableElement)
element).getParameters()) {
- if (!first) {
- fqnSB.append(", ");
- }
-
fqnSB.append(info.getTypeUtilities().getTypeName(info.getTypes().erasure(var.asType())));
- first = false;
- }
- } else {
- fqnSB.append("..."); // NOI18N
- }
- fqnSB.append(')'); // NOI18N
+ fqnSB.append("(...)"); // NOI18N
Review comment:
What a simplification!
##########
File path: .travis.yml
##########
@@ -363,7 +363,7 @@ matrix:
#- ant $OPTS -f java/java.kit test
#- ant $OPTS -f java/java.lexer test
#- ant $OPTS -f java/java.lexer test
- #- ant $OPTS -f java/java.lsp.server test
+ - ant $OPTS -f java/java.lsp.server test
Review comment:
Great!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
