jlahoda commented on pull request #3227: URL: https://github.com/apache/netbeans/pull/3227#issuecomment-948281949
Thanks for the test, but please return the golden files to the 1.8 folder - the golden files are based on the runtime platform, not on the source level (as e.g. the content of `java.lang` differs across JDK versions). It is a bit confusing to run JDK 14+ language feature tests on JDK 8, but without that, we would have no coverage of these features on 8-13. (The tests runs with nb-javac on JDK 8, so the javac can understand records, just the runtime has a different content of things like `java.lang`.) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
