sdedic commented on a change in pull request #3321:
URL: https://github.com/apache/netbeans/pull/3321#discussion_r751016270
##########
File path:
java/java.source.base/src/org/netbeans/modules/java/source/parsing/JavacParser.java
##########
@@ -805,6 +801,10 @@ Phase moveToPhase (final Phase phase, final
CompilationInfoImpl currentInfo, Lis
}
}
} finally {
+ if (lowMemoryCancel.get()) {
Review comment:
OK, centralized low-memory conditions for all types of failures, not
just Runtime + CancelAbort.
##########
File path:
java/java.source.base/src/org/netbeans/modules/java/source/parsing/JavacParser.java
##########
@@ -772,29 +772,25 @@ Phase moveToPhase (final Phase phase, final
CompilationInfoImpl currentInfo, Lis
compiler.todo.offer(env);
}
}
- currentPhase = Phase.RESOLVED;
+ if (!lowMemoryCancel.get()) {
Review comment:
Completed without an exception/error, but still low memory cancel ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
