junichi11 commented on a change in pull request #3331:
URL: https://github.com/apache/netbeans/pull/3331#discussion_r755607933
##########
File path: php/php.editor/tools/ASTPHP5Parser.cup
##########
@@ -3022,7 +3045,15 @@ method_modifiers ::=
RESULT = Integer.valueOf(result);
:}
-| af_modifiers:fModifier ppp_modifiers:sModifier
+| abstract_modifier:aModifier ppp_modifiers:sModifier
+{:
+ int result = 0;
+ result |= aModifier.intValue();
+ result |= sModifier.intValue();
+ RESULT = Integer.valueOf(result);
+:}
+
+| final_modifier:fModifier ppp_modifiers:sModifier
Review comment:
`method_modifiers ::=` part
Why did separate `abstract` and `final`?
The reason: because the following cases are marked as syntax errors...
(I'm not sure the cause...)
```php
final public function method() {}
final public static function method() {}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
