JaroslavTulach commented on a change in pull request #3323: URL: https://github.com/apache/netbeans/pull/3323#discussion_r755852320
########## File path: java/java.lsp.server/nbcode/integration/src/org/netbeans/modules/nbcode/integration/layer.xml ########## @@ -21,6 +21,11 @@ --> <!DOCTYPE filesystem PUBLIC "-//NetBeans//DTD Filesystem 1.2//EN" "http://www.netbeans.org/dtds/filesystem-1_2.dtd";> <filesystem> + <folder name="Explorers"> + <folder name="_all"> + <file name="standard-cookies.contextValues" url="standard-cookies.contextValues"/> Review comment: Interesting API. Is it documented somewhere? I'd rather use `<attr ..../>` than content of a file, however. ########## File path: ide/projectuiapi.base/src/org/netbeans/api/project/ui/OpenProjects.java ########## @@ -315,5 +314,24 @@ public void addProjectGroupChangeListener( @NonNull ProjectGroupChangeListener l public void removeProjectGroupChangeListener( @NonNull ProjectGroupChangeListener listener) { trampoline.removeProjectGroupChangeListenerAPI(listener); } - + + /** Creates new {@link ExplorerManager} to show and control + * logical structure of a project. + * + * @return new instance of the manager + * @since 1.100 + */ + public ExplorerManager createLogicalView() { Review comment: This API has to be documented in apichanges. Sorry for not doing that to begin with. ########## File path: java/java.lsp.server/vscode/.vscode/launch.json ########## @@ -31,7 +31,10 @@ "outFiles": [ "${workspaceFolder}/out/test/**/*.js" ], - "preLaunchTask": "${defaultBuildTask}" + "preLaunchTask": "${defaultBuildTask}", + "env": { + "netbeans.extra.options" : "-J-Dproject.limitScanRoot=${workspaceFolder}/out" Review comment: An API to document as `<api category="systemproperty" />` somewhere. ########## File path: java/java.lsp.server/vscode/src/explorer.ts ########## @@ -0,0 +1,227 @@ +import * as vscode from 'vscode'; Review comment: File without a license header!? ########## File path: java/java.lsp.server/src/org/netbeans/modules/java/lsp/server/explorer/ProjectExplorer.java ########## @@ -0,0 +1,47 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.netbeans.modules.java.lsp.server.explorer; + +import org.netbeans.modules.java.lsp.server.explorer.api.ExplorerManagerFactory; +import java.util.concurrent.CompletableFuture; +import java.util.concurrent.CompletionStage; +import org.netbeans.api.project.ui.OpenProjects; +import org.openide.explorer.ExplorerManager; +import org.openide.util.Lookup; +import org.openide.util.RequestProcessor; +import org.openide.util.lookup.ServiceProvider; + +/** + * + * @author sdedic + */ +@ServiceProvider(path = "Explorers/" + ProjectExplorer.ID_PROJECT_LOGICAL_VIEW, service = ExplorerManagerFactory.class) Review comment: Please document somewhere (in this PR?) steps to add new treeview even it is just a private API in `java.lsp.server` module. ########## File path: java/java.lsp.server/nbcode/integration/src/org/netbeans/modules/nbcode/integration/standard-cookies.contextValues ########## @@ -0,0 +1,25 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +# Use fully qualified names, one class per line. Syntax is: +# qualified.name=value : value will be used instead of qualified name. +# [prefix.]qualified.name : the prefix will be stripped +# [prefix=subst] : the prefix in all classes will be replaced by subst, possibly empty +# * as the first character: watch for changes in this interface, fire changes. +# Names will be converted to "class:<name>" tokens. + +org.netbeans.api.actions.Openable Review comment: None of the descriptions at line 18-21 seem to match `org.netbeans.api.actions.Openable` - I have no idea what it does. ########## File path: java/java.lsp.server/src/org/netbeans/modules/java/lsp/server/explorer/api/ExplorerManagerFactory.java ########## @@ -0,0 +1,43 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.netbeans.modules.java.lsp.server.explorer.api; + +import java.util.concurrent.CompletionStage; +import org.openide.explorer.ExplorerManager; +import org.openide.util.Lookup; + +/** + * Factory that produces an ExplorerManager that serves node in a specified tree structure. The + * Factory has to be registered as a named service on path {@code Explorers/<id>}; first registration + * wins. + * <p> + * Note: this interface will become an API independent of LSP. Review comment: Great. Include steps & references to what needs to be done, please. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
