matthiasblaesing commented on a change in pull request #3328:
URL: https://github.com/apache/netbeans/pull/3328#discussion_r757776251
##########
File path: nbbuild/antsrc/org/netbeans/nbbuild/extlibs/ignored-overlaps
##########
@@ -32,7 +32,8 @@ ide/db.dataview/external/commons-compress-1.20.jar
java/java.disco/external/comm
# It happens that maven 3.3.9 uses commons-lang-2.6.jar, same as
o.apache.commons.lang
# and commons-io-2.5.jar, same as java.lsp.server
# These are used independently, different functional goals
-java/java.lsp.server/external/commons-io-2.5.jar
java/maven.embedder/external/apache-maven-3.6.3-bin.zip
+# maven 3.8.4 use common-io-2.6
java/java.lsp.server/external/commons-io-2.5.jar
java/maven.embedder/external/apache-maven-3.6.3-bin.zip
+platform/o.apache.commons.io/external/commons-io-2.6.jar
java/maven.embedder/external/apache-maven-3.8.4-bin.zip
Review comment:
The alternative would be to add a dependency on the netbeans module.
`maven.embedder` already seems to depend on `commons-logging` (this could most
probably be removed)
##########
File path: nbbuild/antsrc/org/netbeans/nbbuild/extlibs/ignored-overlaps
##########
@@ -71,7 +76,7 @@ extide/gradle/external/gradle-7.3-bin.zip
ide/c.jcraft.jzlib/external/jzlib-1.1.
extide/gradle/external/gradle-7.3-bin.zip
ide/libs.antlr4.runtime/external/antlr4-runtime-4.7.2.jar
extide/gradle/external/gradle-7.3-bin.zip
ide/o.apache.commons.lang/external/commons-lang-2.6.jar
extide/gradle/external/gradle-7.3-bin.zip
ide/o.eclipse.jgit/external/org.eclipse.jgit-5.7.0.202003110725-r.jar
-extide/gradle/external/gradle-7.3-bin.zip
java/maven.embedder/external/apache-maven-3.6.3-bin.zip
+extide/gradle/external/gradle-7.3-bin.zip
java/maven.embedder/external/apache-maven-3.8.4-bin.zip
Review comment:
Is this really needed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
