[GitHub] [netbeans] jtulach commented on a change in pull request #3342: Fixing pattern matching for binding patterns

Sun, 28 Nov 2021 18:56:04 -0800 


jtulach commented on a change in pull request #3342:
URL: https://github.com/apache/netbeans/pull/3342#discussion_r758007685



##########
File path: .travis.yml
##########
@@ -485,111 +485,58 @@ matrix:
           script:
             - ant $OPTS -Dtest.config=batch2 -f java/java.hints test
 
-        - name: Test Java modules without nb-javac on Java 14
+        - name: Test Java modules without nb-javac on Java 17
           jdk: openjdk8
           env:
             - 
OPTS="-Dmetabuild.jsonurl=https://raw.githubusercontent.com/apache/netbeans-jenkins-lib/master/meta/netbeansrelease.json
 -quiet -Dcluster.config=java -Djavac.compilerargs=-nowarn 
-Dbuild.compiler.deprecation=false 
-Dtest-unit-sys-prop.ignore.random.failures=true"
           before_script:
             - wget 
https://raw.githubusercontent.com/sormuras/bach/master/install-jdk.sh
-            - export TEST_JDK=`bash install-jdk.sh --feature 14 --license GPL 
--emit-java-home --silent | tail -1`
-            - export 
OPTS="-Dmetabuild.jsonurl=https://raw.githubusercontent.com/apache/netbeans-jenkins-lib/master/meta/netbeansrelease.json
 $OPTS -Dtest.nbjdk.home=$TEST_JDK -Dtest.use.jdk.javac=true"
-            - ant $OPTS clean
-            - ant $OPTS build
-          script:
-            - ant $OPTS -f java/java.completion test
-            - ant $OPTS -Dtest.config=vanilla-javac -f java/java.source.base 
test
-
-        - name: Test refactoring.java without nb-javac on Java 14
-          jdk: openjdk8
-          env:
-            - 
OPTS="-Dmetabuild.jsonurl=https://raw.githubusercontent.com/apache/netbeans-jenkins-lib/master/meta/netbeansrelease.json
 -quiet -Dcluster.config=java -Djavac.compilerargs=-nowarn 
-Dbuild.compiler.deprecation=false 
-Dtest-unit-sys-prop.ignore.random.failures=true"
-          before_script:
-            - wget 
https://raw.githubusercontent.com/sormuras/bach/master/install-jdk.sh
-            - export TEST_JDK=`bash install-jdk.sh --feature 14 --license GPL 
--emit-java-home --silent | tail -1`
-            - export 
OPTS="-Dmetabuild.jsonurl=https://raw.githubusercontent.com/apache/netbeans-jenkins-lib/master/meta/netbeansrelease.json
 $OPTS -Dtest.nbjdk.home=$TEST_JDK -Dtest.use.jdk.javac=true"
-            - ant $OPTS clean
-            - ant $OPTS build
-          script:
-            - travis_retry ant $OPTS -f java/refactoring.java test-unit
-
-        - name: Test java.hints batch1 without nb-javac on Java 14
-          jdk: openjdk8
-          env:
-            - 
OPTS="-Dmetabuild.jsonurl=https://raw.githubusercontent.com/apache/netbeans-jenkins-lib/master/meta/netbeansrelease.json
 -quiet -Dcluster.config=java -Djavac.compilerargs=-nowarn 
-Dbuild.compiler.deprecation=false 
-Dtest-unit-sys-prop.ignore.random.failures=true"
-          before_script:
-            - wget 
https://raw.githubusercontent.com/sormuras/bach/master/install-jdk.sh
-            - export TEST_JDK=`bash install-jdk.sh --feature 14 --license GPL 
--emit-java-home --silent | tail -1`
-            - export 
OPTS="-Dmetabuild.jsonurl=https://raw.githubusercontent.com/apache/netbeans-jenkins-lib/master/meta/netbeansrelease.json
 $OPTS -Dtest.nbjdk.home=$TEST_JDK -Dtest.use.jdk.javac=true"
-            - ant $OPTS clean
-            - ant $OPTS build
-          script:
-            - ant $OPTS -Dtest.config=batch1-vanilla-javac -f java/java.hints 
test
-
-        - name: Test java.hints batch2 without nb-javac on Java 14
-          jdk: openjdk8
-          env:
-            - 
OPTS="-Dmetabuild.jsonurl=https://raw.githubusercontent.com/apache/netbeans-jenkins-lib/master/meta/netbeansrelease.json
 -quiet -Dcluster.config=java -Djavac.compilerargs=-nowarn 
-Dbuild.compiler.deprecation=false 
-Dtest-unit-sys-prop.ignore.random.failures=true"
-          before_script:
-            - wget 
https://raw.githubusercontent.com/sormuras/bach/master/install-jdk.sh
-            - export TEST_JDK=`bash install-jdk.sh --feature 14 --license GPL 
--emit-java-home --silent | tail -1`
+            - export TEST_JDK=`bash install-jdk.sh --feature 17 --license GPL 
--emit-java-home --silent | tail -1`
             - export 
OPTS="-Dmetabuild.jsonurl=https://raw.githubusercontent.com/apache/netbeans-jenkins-lib/master/meta/netbeansrelease.json
 $OPTS -Dtest.nbjdk.home=$TEST_JDK -Dtest.use.jdk.javac=true"
             - ant $OPTS clean
             - ant $OPTS build
           script:
-            - ant $OPTS -Dtest.config=batch2-vanilla-javac -f java/java.hints 
test
+            - ant $OPTS -f java/java.completion 
"-Dtest.run.args=--add-opens=java.base/java.net=ALL-UNNAMED 
--add-opens=java.prefs/java.util.prefs=ALL-UNNAMED 
--add-exports=jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED 
--add-exports=jdk.compiler/com.sun.tools.javac.code=ALL-UNNAMED 
--add-exports=jdk.compiler/com.sun.tools.javac.comp=ALL-UNNAMED 
--add-exports=jdk.compiler/com.sun.tools.javac.file=ALL-UNNAMED 
--add-exports=jdk.compiler/com.sun.tools.javac.jvm=ALL-UNNAMED 
--add-exports=jdk.compiler/com.sun.tools.javac.main=ALL-UNNAMED 
--add-exports=jdk.compiler/com.sun.tools.javac.model=ALL-UNNAMED 
--add-exports=jdk.compiler/com.sun.tools.javac.parser=ALL-UNNAMED 
--add-exports=jdk.compiler/com.sun.tools.javac.processing=ALL-UNNAMED 
--add-exports=jdk.compiler/com.sun.tools.javac.tree=ALL-UNNAMED 
--add-exports=jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED  
--add-opens=jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED 
--add-opens=jdk.compiler/com.sun.tools.javac.code=ALL-UNNAMED --a
 dd-opens=jdk.compiler/com.sun.tools.javac.comp=ALL-UNNAMED 
--add-opens=jdk.compiler/com.sun.tools.javac.file=ALL-UNNAMED 
--add-opens=jdk.compiler/com.sun.tools.javac.jvm=ALL-UNNAMED 
--add-opens=jdk.compiler/com.sun.tools.javac.main=ALL-UNNAMED 
--add-opens=jdk.compiler/com.sun.tools.javac.model=ALL-UNNAMED 
--add-opens=jdk.compiler/com.sun.tools.javac.parser=ALL-UNNAMED 
--add-opens=jdk.compiler/com.sun.tools.javac.processing=ALL-UNNAMED 
--add-opens=jdk.compiler/com.sun.tools.javac.tree=ALL-UNNAMED 
--add-opens=jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED 
--add-opens=java.desktop/javax.swing.text=ALL-UNNAMED 
--add-opens=jdk.jdeps/com.sun.tools.classfile=ALL-UNNAMED 
--add-exports=jdk.jdeps/com.sun.tools.classfile=ALL-UNNAMED 
--add-opens=jdk.jdeps/com.sun.tools.javap=ALL-UNNAMED 
--add-exports=jdk.jdeps/com.sun.tools.javap=ALL-UNNAMED 
--add-opens=java.base/java.security=ALL-UNNAMED 
--add-exports=java.base/java.security=ALL-UNNAMED 
--add-opens=java.base/sun.reflect.annotation=ALL-UNNAM
 ED --add-exports=java.base/sun.reflect.annotation=ALL-UNNAMED" test
+            - ant $OPTS -Dtest.config=vanilla-javac -f java/java.source.base 
"-Dtest.run.args=--add-opens=java.base/java.net=ALL-UNNAMED 
--add-opens=java.prefs/java.util.prefs=ALL-UNNAMED 
--add-exports=jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED 
--add-exports=jdk.compiler/com.sun.tools.javac.code=ALL-UNNAMED 
--add-exports=jdk.compiler/com.sun.tools.javac.comp=ALL-UNNAMED 
--add-exports=jdk.compiler/com.sun.tools.javac.file=ALL-UNNAMED 
--add-exports=jdk.compiler/com.sun.tools.javac.jvm=ALL-UNNAMED 
--add-exports=jdk.compiler/com.sun.tools.javac.main=ALL-UNNAMED 
--add-exports=jdk.compiler/com.sun.tools.javac.model=ALL-UNNAMED 
--add-exports=jdk.compiler/com.sun.tools.javac.parser=ALL-UNNAMED 
--add-exports=jdk.compiler/com.sun.tools.javac.processing=ALL-UNNAMED 
--add-exports=jdk.compiler/com.sun.tools.javac.tree=ALL-UNNAMED 
--add-exports=jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED  
--add-opens=jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED 
--add-opens=jdk.compiler/com.sun.too
 ls.javac.code=ALL-UNNAMED 
--add-opens=jdk.compiler/com.sun.tools.javac.comp=ALL-UNNAMED 
--add-opens=jdk.compiler/com.sun.tools.javac.file=ALL-UNNAMED 
--add-opens=jdk.compiler/com.sun.tools.javac.jvm=ALL-UNNAMED 
--add-opens=jdk.compiler/com.sun.tools.javac.main=ALL-UNNAMED 
--add-opens=jdk.compiler/com.sun.tools.javac.model=ALL-UNNAMED 
--add-opens=jdk.compiler/com.sun.tools.javac.parser=ALL-UNNAMED 
--add-opens=jdk.compiler/com.sun.tools.javac.processing=ALL-UNNAMED 
--add-opens=jdk.compiler/com.sun.tools.javac.tree=ALL-UNNAMED 
--add-opens=jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED 
--add-opens=java.desktop/javax.swing.text=ALL-UNNAMED 
--add-opens=jdk.jdeps/com.sun.tools.classfile=ALL-UNNAMED 
--add-exports=jdk.jdeps/com.sun.tools.classfile=ALL-UNNAMED 
--add-opens=jdk.jdeps/com.sun.tools.javap=ALL-UNNAMED 
--add-exports=jdk.jdeps/com.sun.tools.javap=ALL-UNNAMED 
--add-opens=java.base/java.security=ALL-UNNAMED 
--add-exports=java.base/java.security=ALL-UNNAMED --add-opens=java.base/sun
 .reflect.annotation=ALL-UNNAMED 
--add-exports=java.base/sun.reflect.annotation=ALL-UNNAMED" test
 
-        - name: Test Java modules without nb-javac on Java 15
+        - name: Test refactoring.java without nb-javac on Java 17
           jdk: openjdk8
           env:
             - 
OPTS="-Dmetabuild.jsonurl=https://raw.githubusercontent.com/apache/netbeans-jenkins-lib/master/meta/netbeansrelease.json
 -quiet -Dcluster.config=java -Djavac.compilerargs=-nowarn 
-Dbuild.compiler.deprecation=false 
-Dtest-unit-sys-prop.ignore.random.failures=true"
           before_script:
             - wget 
https://raw.githubusercontent.com/sormuras/bach/master/install-jdk.sh
-            - export TEST_JDK=`bash install-jdk.sh --feature 15 --license GPL 
--emit-java-home --silent | tail -1`
+            - export TEST_JDK=`bash install-jdk.sh --feature 17 --license GPL 
--emit-java-home --silent | tail -1`
             - export 
OPTS="-Dmetabuild.jsonurl=https://raw.githubusercontent.com/apache/netbeans-jenkins-lib/master/meta/netbeansrelease.json
 $OPTS -Dtest.nbjdk.home=$TEST_JDK -Dtest.use.jdk.javac=true"
             - ant $OPTS clean
             - ant $OPTS build
           script:
-            - ant $OPTS -f java/java.completion test
-            - ant $OPTS -Dtest.config=vanilla-javac -f java/java.source.base 
test
+            - travis_retry ant $OPTS -f java/refactoring.java 
"-Dtest.run.args=--add-opens=java.base/java.net=ALL-UNNAMED 
--add-opens=java.prefs/java.util.prefs=ALL-UNNAMED 
--add-exports=jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED 
--add-exports=jdk.compiler/com.sun.tools.javac.code=ALL-UNNAMED 
--add-exports=jdk.compiler/com.sun.tools.javac.comp=ALL-UNNAMED 
--add-exports=jdk.compiler/com.sun.tools.javac.file=ALL-UNNAMED 
--add-exports=jdk.compiler/com.sun.tools.javac.jvm=ALL-UNNAMED 
--add-exports=jdk.compiler/com.sun.tools.javac.main=ALL-UNNAMED 
--add-exports=jdk.compiler/com.sun.tools.javac.model=ALL-UNNAMED 
--add-exports=jdk.compiler/com.sun.tools.javac.parser=ALL-UNNAMED 
--add-exports=jdk.compiler/com.sun.tools.javac.processing=ALL-UNNAMED 
--add-exports=jdk.compiler/com.sun.tools.javac.tree=ALL-UNNAMED 
--add-exports=jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED  
--add-opens=jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED 
--add-opens=jdk.compiler/com.sun.tools.javac.code=A
 LL-UNNAMED --add-opens=jdk.compiler/com.sun.tools.javac.comp=ALL-UNNAMED 
--add-opens=jdk.compiler/com.sun.tools.javac.file=ALL-UNNAMED 
--add-opens=jdk.compiler/com.sun.tools.javac.jvm=ALL-UNNAMED 
--add-opens=jdk.compiler/com.sun.tools.javac.main=ALL-UNNAMED 
--add-opens=jdk.compiler/com.sun.tools.javac.model=ALL-UNNAMED 
--add-opens=jdk.compiler/com.sun.tools.javac.parser=ALL-UNNAMED 
--add-opens=jdk.compiler/com.sun.tools.javac.processing=ALL-UNNAMED 
--add-opens=jdk.compiler/com.sun.tools.javac.tree=ALL-UNNAMED 
--add-opens=jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED 
--add-opens=java.desktop/javax.swing.text=ALL-UNNAMED 
--add-opens=jdk.jdeps/com.sun.tools.classfile=ALL-UNNAMED 
--add-exports=jdk.jdeps/com.sun.tools.classfile=ALL-UNNAMED 
--add-opens=jdk.jdeps/com.sun.tools.javap=ALL-UNNAMED 
--add-exports=jdk.jdeps/com.sun.tools.javap=ALL-UNNAMED 
--add-opens=java.base/java.security=ALL-UNNAMED 
--add-exports=java.base/java.security=ALL-UNNAMED 
--add-opens=java.base/sun.reflect.annota
 tion=ALL-UNNAMED --add-exports=java.base/sun.reflect.annotation=ALL-UNNAMED" 
test-unit
 
-        - name: Test refactoring.java without nb-javac on Java 15
+        - name: Test java.hints batch1 without nb-javac on Java 17

Review comment:
       Dropping testing on JDK15 in favor of JDK17 is great!

##########
File path: .travis.yml
##########
@@ -485,111 +485,58 @@ matrix:
           script:
             - ant $OPTS -Dtest.config=batch2 -f java/java.hints test
 
-        - name: Test Java modules without nb-javac on Java 14
+        - name: Test Java modules without nb-javac on Java 17
           jdk: openjdk8
           env:
             - 
OPTS="-Dmetabuild.jsonurl=https://raw.githubusercontent.com/apache/netbeans-jenkins-lib/master/meta/netbeansrelease.json
 -quiet -Dcluster.config=java -Djavac.compilerargs=-nowarn 
-Dbuild.compiler.deprecation=false 
-Dtest-unit-sys-prop.ignore.random.failures=true"
           before_script:
             - wget 
https://raw.githubusercontent.com/sormuras/bach/master/install-jdk.sh
-            - export TEST_JDK=`bash install-jdk.sh --feature 14 --license GPL 
--emit-java-home --silent | tail -1`
-            - export 
OPTS="-Dmetabuild.jsonurl=https://raw.githubusercontent.com/apache/netbeans-jenkins-lib/master/meta/netbeansrelease.json
 $OPTS -Dtest.nbjdk.home=$TEST_JDK -Dtest.use.jdk.javac=true"
-            - ant $OPTS clean
-            - ant $OPTS build
-          script:
-            - ant $OPTS -f java/java.completion test
-            - ant $OPTS -Dtest.config=vanilla-javac -f java/java.source.base 
test
-
-        - name: Test refactoring.java without nb-javac on Java 14
-          jdk: openjdk8
-          env:
-            - 
OPTS="-Dmetabuild.jsonurl=https://raw.githubusercontent.com/apache/netbeans-jenkins-lib/master/meta/netbeansrelease.json
 -quiet -Dcluster.config=java -Djavac.compilerargs=-nowarn 
-Dbuild.compiler.deprecation=false 
-Dtest-unit-sys-prop.ignore.random.failures=true"
-          before_script:
-            - wget 
https://raw.githubusercontent.com/sormuras/bach/master/install-jdk.sh
-            - export TEST_JDK=`bash install-jdk.sh --feature 14 --license GPL 
--emit-java-home --silent | tail -1`
-            - export 
OPTS="-Dmetabuild.jsonurl=https://raw.githubusercontent.com/apache/netbeans-jenkins-lib/master/meta/netbeansrelease.json
 $OPTS -Dtest.nbjdk.home=$TEST_JDK -Dtest.use.jdk.javac=true"
-            - ant $OPTS clean
-            - ant $OPTS build
-          script:
-            - travis_retry ant $OPTS -f java/refactoring.java test-unit
-
-        - name: Test java.hints batch1 without nb-javac on Java 14
-          jdk: openjdk8
-          env:
-            - 
OPTS="-Dmetabuild.jsonurl=https://raw.githubusercontent.com/apache/netbeans-jenkins-lib/master/meta/netbeansrelease.json
 -quiet -Dcluster.config=java -Djavac.compilerargs=-nowarn 
-Dbuild.compiler.deprecation=false 
-Dtest-unit-sys-prop.ignore.random.failures=true"
-          before_script:
-            - wget 
https://raw.githubusercontent.com/sormuras/bach/master/install-jdk.sh
-            - export TEST_JDK=`bash install-jdk.sh --feature 14 --license GPL 
--emit-java-home --silent | tail -1`
-            - export 
OPTS="-Dmetabuild.jsonurl=https://raw.githubusercontent.com/apache/netbeans-jenkins-lib/master/meta/netbeansrelease.json
 $OPTS -Dtest.nbjdk.home=$TEST_JDK -Dtest.use.jdk.javac=true"
-            - ant $OPTS clean
-            - ant $OPTS build
-          script:
-            - ant $OPTS -Dtest.config=batch1-vanilla-javac -f java/java.hints 
test
-
-        - name: Test java.hints batch2 without nb-javac on Java 14
-          jdk: openjdk8
-          env:
-            - 
OPTS="-Dmetabuild.jsonurl=https://raw.githubusercontent.com/apache/netbeans-jenkins-lib/master/meta/netbeansrelease.json
 -quiet -Dcluster.config=java -Djavac.compilerargs=-nowarn 
-Dbuild.compiler.deprecation=false 
-Dtest-unit-sys-prop.ignore.random.failures=true"
-          before_script:
-            - wget 
https://raw.githubusercontent.com/sormuras/bach/master/install-jdk.sh
-            - export TEST_JDK=`bash install-jdk.sh --feature 14 --license GPL 
--emit-java-home --silent | tail -1`
+            - export TEST_JDK=`bash install-jdk.sh --feature 17 --license GPL 
--emit-java-home --silent | tail -1`
             - export 
OPTS="-Dmetabuild.jsonurl=https://raw.githubusercontent.com/apache/netbeans-jenkins-lib/master/meta/netbeansrelease.json
 $OPTS -Dtest.nbjdk.home=$TEST_JDK -Dtest.use.jdk.javac=true"
             - ant $OPTS clean
             - ant $OPTS build
           script:
-            - ant $OPTS -Dtest.config=batch2-vanilla-javac -f java/java.hints 
test
+            - ant $OPTS -f java/java.completion 
"-Dtest.run.args=--add-opens=java.base/java.net=ALL-UNNAMED 
--add-opens=java.prefs/java.util.prefs=ALL-UNNAMED 
--add-exports=jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED 
--add-exports=jdk.compiler/com.sun.tools.javac.code=ALL-UNNAMED 
--add-exports=jdk.compiler/com.sun.tools.javac.comp=ALL-UNNAMED 
--add-exports=jdk.compiler/com.sun.tools.javac.file=ALL-UNNAMED 
--add-exports=jdk.compiler/com.sun.tools.javac.jvm=ALL-UNNAMED 
--add-exports=jdk.compiler/com.sun.tools.javac.main=ALL-UNNAMED 
--add-exports=jdk.compiler/com.sun.tools.javac.model=ALL-UNNAMED 
--add-exports=jdk.compiler/com.sun.tools.javac.parser=ALL-UNNAMED 
--add-exports=jdk.compiler/com.sun.tools.javac.processing=ALL-UNNAMED 
--add-exports=jdk.compiler/com.sun.tools.javac.tree=ALL-UNNAMED 
--add-exports=jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED  
--add-opens=jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED 
--add-opens=jdk.compiler/com.sun.tools.javac.code=ALL-UNNAMED --a
 dd-opens=jdk.compiler/com.sun.tools.javac.comp=ALL-UNNAMED 
--add-opens=jdk.compiler/com.sun.tools.javac.file=ALL-UNNAMED 
--add-opens=jdk.compiler/com.sun.tools.javac.jvm=ALL-UNNAMED 
--add-opens=jdk.compiler/com.sun.tools.javac.main=ALL-UNNAMED 
--add-opens=jdk.compiler/com.sun.tools.javac.model=ALL-UNNAMED 
--add-opens=jdk.compiler/com.sun.tools.javac.parser=ALL-UNNAMED 
--add-opens=jdk.compiler/com.sun.tools.javac.processing=ALL-UNNAMED 
--add-opens=jdk.compiler/com.sun.tools.javac.tree=ALL-UNNAMED 
--add-opens=jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED 
--add-opens=java.desktop/javax.swing.text=ALL-UNNAMED 
--add-opens=jdk.jdeps/com.sun.tools.classfile=ALL-UNNAMED 
--add-exports=jdk.jdeps/com.sun.tools.classfile=ALL-UNNAMED 
--add-opens=jdk.jdeps/com.sun.tools.javap=ALL-UNNAMED 
--add-exports=jdk.jdeps/com.sun.tools.javap=ALL-UNNAMED 
--add-opens=java.base/java.security=ALL-UNNAMED 
--add-exports=java.base/java.security=ALL-UNNAMED 
--add-opens=java.base/sun.reflect.annotation=ALL-UNNAM
 ED --add-exports=java.base/sun.reflect.annotation=ALL-UNNAMED" test
+            - ant $OPTS -Dtest.config=vanilla-javac -f java/java.source.base 
"-Dtest.run.args=--add-opens=java.base/java.net=ALL-UNNAMED 
--add-opens=java.prefs/java.util.prefs=ALL-UNNAMED 
--add-exports=jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED 
--add-exports=jdk.compiler/com.sun.tools.javac.code=ALL-UNNAMED 
--add-exports=jdk.compiler/com.sun.tools.javac.comp=ALL-UNNAMED 
--add-exports=jdk.compiler/com.sun.tools.javac.file=ALL-UNNAMED 
--add-exports=jdk.compiler/com.sun.tools.javac.jvm=ALL-UNNAMED 
--add-exports=jdk.compiler/com.sun.tools.javac.main=ALL-UNNAMED 
--add-exports=jdk.compiler/com.sun.tools.javac.model=ALL-UNNAMED 
--add-exports=jdk.compiler/com.sun.tools.javac.parser=ALL-UNNAMED 
--add-exports=jdk.compiler/com.sun.tools.javac.processing=ALL-UNNAMED 
--add-exports=jdk.compiler/com.sun.tools.javac.tree=ALL-UNNAMED 
--add-exports=jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED  
--add-opens=jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED 
--add-opens=jdk.compiler/com.sun.too
 ls.javac.code=ALL-UNNAMED 
--add-opens=jdk.compiler/com.sun.tools.javac.comp=ALL-UNNAMED 
--add-opens=jdk.compiler/com.sun.tools.javac.file=ALL-UNNAMED 
--add-opens=jdk.compiler/com.sun.tools.javac.jvm=ALL-UNNAMED 
--add-opens=jdk.compiler/com.sun.tools.javac.main=ALL-UNNAMED 
--add-opens=jdk.compiler/com.sun.tools.javac.model=ALL-UNNAMED 
--add-opens=jdk.compiler/com.sun.tools.javac.parser=ALL-UNNAMED 
--add-opens=jdk.compiler/com.sun.tools.javac.processing=ALL-UNNAMED 
--add-opens=jdk.compiler/com.sun.tools.javac.tree=ALL-UNNAMED 
--add-opens=jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED 
--add-opens=java.desktop/javax.swing.text=ALL-UNNAMED 
--add-opens=jdk.jdeps/com.sun.tools.classfile=ALL-UNNAMED 
--add-exports=jdk.jdeps/com.sun.tools.classfile=ALL-UNNAMED 
--add-opens=jdk.jdeps/com.sun.tools.javap=ALL-UNNAMED 
--add-exports=jdk.jdeps/com.sun.tools.javap=ALL-UNNAMED 
--add-opens=java.base/java.security=ALL-UNNAMED 
--add-exports=java.base/java.security=ALL-UNNAMED --add-opens=java.base/sun
 .reflect.annotation=ALL-UNNAMED 
--add-exports=java.base/sun.reflect.annotation=ALL-UNNAMED" test
 
-        - name: Test Java modules without nb-javac on Java 15
+        - name: Test refactoring.java without nb-javac on Java 17
           jdk: openjdk8
           env:
             - 
OPTS="-Dmetabuild.jsonurl=https://raw.githubusercontent.com/apache/netbeans-jenkins-lib/master/meta/netbeansrelease.json
 -quiet -Dcluster.config=java -Djavac.compilerargs=-nowarn 
-Dbuild.compiler.deprecation=false 
-Dtest-unit-sys-prop.ignore.random.failures=true"
           before_script:
             - wget 
https://raw.githubusercontent.com/sormuras/bach/master/install-jdk.sh
-            - export TEST_JDK=`bash install-jdk.sh --feature 15 --license GPL 
--emit-java-home --silent | tail -1`
+            - export TEST_JDK=`bash install-jdk.sh --feature 17 --license GPL 
--emit-java-home --silent | tail -1`
             - export 
OPTS="-Dmetabuild.jsonurl=https://raw.githubusercontent.com/apache/netbeans-jenkins-lib/master/meta/netbeansrelease.json
 $OPTS -Dtest.nbjdk.home=$TEST_JDK -Dtest.use.jdk.javac=true"
             - ant $OPTS clean
             - ant $OPTS build
           script:
-            - ant $OPTS -f java/java.completion test
-            - ant $OPTS -Dtest.config=vanilla-javac -f java/java.source.base 
test
+            - travis_retry ant $OPTS -f java/refactoring.java 
"-Dtest.run.args=--add-opens=java.base/java.net=ALL-UNNAMED 
--add-opens=java.prefs/java.util.prefs=ALL-UNNAMED 
--add-exports=jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED 
--add-exports=jdk.compiler/com.sun.tools.javac.code=ALL-UNNAMED 
--add-exports=jdk.compiler/com.sun.tools.javac.comp=ALL-UNNAMED 
--add-exports=jdk.compiler/com.sun.tools.javac.file=ALL-UNNAMED 
--add-exports=jdk.compiler/com.sun.tools.javac.jvm=ALL-UNNAMED 
--add-exports=jdk.compiler/com.sun.tools.javac.main=ALL-UNNAMED 
--add-exports=jdk.compiler/com.sun.tools.javac.model=ALL-UNNAMED 
--add-exports=jdk.compiler/com.sun.tools.javac.parser=ALL-UNNAMED 
--add-exports=jdk.compiler/com.sun.tools.javac.processing=ALL-UNNAMED 
--add-exports=jdk.compiler/com.sun.tools.javac.tree=ALL-UNNAMED 
--add-exports=jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED  
--add-opens=jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED 
--add-opens=jdk.compiler/com.sun.tools.javac.code=A
 LL-UNNAMED --add-opens=jdk.compiler/com.sun.tools.javac.comp=ALL-UNNAMED 
--add-opens=jdk.compiler/com.sun.tools.javac.file=ALL-UNNAMED 
--add-opens=jdk.compiler/com.sun.tools.javac.jvm=ALL-UNNAMED 
--add-opens=jdk.compiler/com.sun.tools.javac.main=ALL-UNNAMED 
--add-opens=jdk.compiler/com.sun.tools.javac.model=ALL-UNNAMED 
--add-opens=jdk.compiler/com.sun.tools.javac.parser=ALL-UNNAMED 
--add-opens=jdk.compiler/com.sun.tools.javac.processing=ALL-UNNAMED 
--add-opens=jdk.compiler/com.sun.tools.javac.tree=ALL-UNNAMED 
--add-opens=jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED 
--add-opens=java.desktop/javax.swing.text=ALL-UNNAMED 
--add-opens=jdk.jdeps/com.sun.tools.classfile=ALL-UNNAMED 
--add-exports=jdk.jdeps/com.sun.tools.classfile=ALL-UNNAMED 
--add-opens=jdk.jdeps/com.sun.tools.javap=ALL-UNNAMED 
--add-exports=jdk.jdeps/com.sun.tools.javap=ALL-UNNAMED 
--add-opens=java.base/java.security=ALL-UNNAMED 
--add-exports=java.base/java.security=ALL-UNNAMED 
--add-opens=java.base/sun.reflect.annota
 tion=ALL-UNNAMED --add-exports=java.base/sun.reflect.annotation=ALL-UNNAMED" 
test-unit
 
-        - name: Test refactoring.java without nb-javac on Java 15
+        - name: Test java.hints batch1 without nb-javac on Java 17
           jdk: openjdk8
           env:
             - 
OPTS="-Dmetabuild.jsonurl=https://raw.githubusercontent.com/apache/netbeans-jenkins-lib/master/meta/netbeansrelease.json
 -quiet -Dcluster.config=java -Djavac.compilerargs=-nowarn 
-Dbuild.compiler.deprecation=false 
-Dtest-unit-sys-prop.ignore.random.failures=true"
           before_script:
             - wget 
https://raw.githubusercontent.com/sormuras/bach/master/install-jdk.sh
-            - export TEST_JDK=`bash install-jdk.sh --feature 15 --license GPL 
--emit-java-home --silent | tail -1`
+            - export TEST_JDK=`bash install-jdk.sh --feature 17 --license GPL 
--emit-java-home --silent | tail -1`
             - export 
OPTS="-Dmetabuild.jsonurl=https://raw.githubusercontent.com/apache/netbeans-jenkins-lib/master/meta/netbeansrelease.json
 $OPTS -Dtest.nbjdk.home=$TEST_JDK -Dtest.use.jdk.javac=true"
             - ant $OPTS clean
             - ant $OPTS build
           script:
-            - travis_retry ant $OPTS -f java/refactoring.java test-unit
+            - ant $OPTS -Dtest.config=batch1-vanilla-javac -f java/java.hints 
"-Dtest.run.args=--add-opens=java.base/java.net=ALL-UNNAMED 
--add-opens=java.prefs/java.util.prefs=ALL-UNNAMED 
--add-exports=jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED 
--add-exports=jdk.compiler/com.sun.tools.javac.code=ALL-UNNAMED 
--add-exports=jdk.compiler/com.sun.tools.javac.comp=ALL-UNNAMED 
--add-exports=jdk.compiler/com.sun.tools.javac.file=ALL-UNNAMED 
--add-exports=jdk.compiler/com.sun.tools.javac.jvm=ALL-UNNAMED 
--add-exports=jdk.compiler/com.sun.tools.javac.main=ALL-UNNAMED 
--add-exports=jdk.compiler/com.sun.tools.javac.model=ALL-UNNAMED 
--add-exports=jdk.compiler/com.sun.tools.javac.parser=ALL-UNNAMED 
--add-exports=jdk.compiler/com.sun.tools.javac.processing=ALL-UNNAMED 
--add-exports=jdk.compiler/com.sun.tools.javac.tree=ALL-UNNAMED 
--add-exports=jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED  
--add-opens=jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED 
--add-opens=jdk.compiler/com.sun.to
 ols.javac.code=ALL-UNNAMED 
--add-opens=jdk.compiler/com.sun.tools.javac.comp=ALL-UNNAMED 
--add-opens=jdk.compiler/com.sun.tools.javac.file=ALL-UNNAMED 
--add-opens=jdk.compiler/com.sun.tools.javac.jvm=ALL-UNNAMED 
--add-opens=jdk.compiler/com.sun.tools.javac.main=ALL-UNNAMED 
--add-opens=jdk.compiler/com.sun.tools.javac.model=ALL-UNNAMED 
--add-opens=jdk.compiler/com.sun.tools.javac.parser=ALL-UNNAMED 
--add-opens=jdk.compiler/com.sun.tools.javac.processing=ALL-UNNAMED 
--add-opens=jdk.compiler/com.sun.tools.javac.tree=ALL-UNNAMED 
--add-opens=jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED 
--add-opens=java.desktop/javax.swing.text=ALL-UNNAMED 
--add-opens=jdk.jdeps/com.sun.tools.classfile=ALL-UNNAMED 
--add-exports=jdk.jdeps/com.sun.tools.classfile=ALL-UNNAMED 
--add-opens=jdk.jdeps/com.sun.tools.javap=ALL-UNNAMED 
--add-exports=jdk.jdeps/com.sun.tools.javap=ALL-UNNAMED 
--add-opens=java.base/java.security=ALL-UNNAMED 
--add-exports=java.base/java.security=ALL-UNNAMED --add-opens=java.base/su
 n.reflect.annotation=ALL-UNNAMED 
--add-exports=java.base/sun.reflect.annotation=ALL-UNNAMED" test

Review comment:
       That's a very long command line. Consider adding a shell script to 
`nbbuild/travis/*.sh` and just invoking it.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

Reply via email to