jlahoda commented on pull request #3228: URL: https://github.com/apache/netbeans/pull/3228#issuecomment-983010061
> @matthiasblaesing thanks. will do. Would be nice if @jlahoda could take a look. Because i have the suspicion that the golden files still have to be in the 1.8 folder but i am not 100% certain. It depends on whether NB 13 having JDK 17 compatible nb-javac installed by default or not I guess. Yes, I think it would be preferrable to have the in the 1.8 folder. The folders represent the runtime platform, and are unrelated to the source level supported by the Java parser. (If the selected Java parser does not support the source level, the test will be skipped anyway, but I think we are heading to a place where this won't happen normally.) I realize this is fairly confusing. Otherwise looks good! Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
