matthiasblaesing commented on a change in pull request #3349: URL: https://github.com/apache/netbeans/pull/3349#discussion_r761391317
########## File path: java/java.lsp.server/src/org/netbeans/modules/java/lsp/server/ui/AbstractLspHtmlViewer.java ########## @@ -0,0 +1,150 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.netbeans.modules.java.lsp.server.ui; + +import java.net.URL; +import java.util.concurrent.Callable; +import java.util.function.Consumer; +import net.java.html.js.JavaScriptBody; +import org.netbeans.modules.java.lsp.server.htmlui.Browser; +import org.netbeans.modules.java.lsp.server.protocol.HtmlPageParams; +import org.netbeans.spi.htmlui.HtmlViewer; +import org.openide.util.Exceptions; + +public class AbstractLspHtmlViewer implements HtmlViewer<AbstractLspHtmlViewer.View> { + protected AbstractLspHtmlViewer() { + } + + @Override + public View newView(Consumer<String> lifeCycleCallback) { + UIContext ui = UIContext.find(); + return new View(ui, lifeCycleCallback); + } + + @Override + public void makeVisible(View view, Runnable whenReady) { + whenReady.run(); + } + + @Override + public void load(View view, ClassLoader loader, URL pageUrl, Callable<Object> initialize, String[] techIds) { + view.load(pageUrl, initialize); + } + + @JavaScriptBody(args = {}, body = "\n" + + "const vscode = acquireVsCodeApi();\n" // this method can be called only once per WebView existance Review comment: Is this really LSP or is this an API hardcoded against VSCode? ########## File path: java/libs.javacapi/external/binaries-list ########## @@ -15,3 +15,4 @@ # specific language governing permissions and limitations # under the License. B195FD4F74CA4BA8BF5985E9103B96C6F0D9079D com.dukescript.nbjavac:nb-javac:jdk-17+35:api +E748E597EACD349D65869A26FCB99A8B4DF887C2 com.dukescript.nbjavac:nb-javac:jdk-17+35 Review comment: Was this PR not done on a recent master checkout? This change is already in master?! ########## File path: java/java.lsp.server/src/org/netbeans/modules/java/lsp/server/refactoring/ui/codicon.css ########## @@ -0,0 +1,485 @@ +/*--------------------------------------------------------------------------------------------- + * Copyright (c) Microsoft Corporation. All rights reserved. + * Licensed under the MIT License. See License.txt in the project root for license information. + *--------------------------------------------------------------------------------------------*/ Review comment: I assume, that the ttf file is under the same license?! Please add an entry for the `codicon.ttf` to `license-info.xml`. The same is true for other font and graphics files (I see `newHTML.png`). ########## File path: platform/generic/manifest.mf ########## @@ -0,0 +1 @@ +OpenIDE-Module: generic Review comment: The name is not good. ########## File path: nb/updatecenters/extras/nbjavac.impl/build/no-license.txt ########## @@ -0,0 +1 @@ +[NO LICENSE SPECIFIED] Review comment: This confirms, that this reintroduces changes, that were already reviewed and in this case is broken. Please drop all changes relating to the nbjavac changes from this and rebase the remaining parts onto master. That should ensure, that no regressions are pulled in. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
