mbien commented on pull request #3418: URL: https://github.com/apache/netbeans/pull/3418#issuecomment-1006595058
I like this. But tbh I am a bit surprised that we are actually building release builds on JDK 11. Since we can't put target to 11, I am not sure what the benefit is to build on 11 (beside validating that the build works which is a good thing). As long NB has the requirement to run on 8, we should build on 8 and test the build everywhere else (8, 11, 17, current) [1]. This PR is a good safety measure, but this should not have happened in the first place IMO. [1] rudimentary example of gh actions i once used for debugging, builds on 8, uploads the artifact and tests everywhere else: https://github.com/mbien/netbeans/blob/d61f3b6ccf0e92e7f570fc912608a455186813c8/.github/workflows/main.yml#L37 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
