JaroslavTulach commented on a change in pull request #3420:
URL: https://github.com/apache/netbeans/pull/3420#discussion_r780626625
##########
File path:
java/java.lsp.server/src/org/netbeans/modules/java/lsp/server/ui/AbstractLspInputOutputProvider.java
##########
@@ -165,8 +166,13 @@ public void close() {
this.in = in;
}
+ boolean isClosed() {
+ return out.closed && err.closed;
+ }
+
private final class LspWriter extends Writer {
private final boolean stdIO;
+ volatile boolean closed;
Review comment:
I wanted to ask: "who sets this field?" as that isn't apparent from this
diff. However there already is `close()` method in this class which was setting
the outer class `closed` - by moving it, it now sets this field. OK.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
