JaroslavTulach commented on a change in pull request #3414:
URL: https://github.com/apache/netbeans/pull/3414#discussion_r780809937
##########
File path:
java/java.lsp.server/src/org/netbeans/modules/java/lsp/server/explorer/TreeItem.java
##########
@@ -56,6 +57,11 @@
public String resourceUri;
// ?: string | MarkdownString | undefined
public Object tooltip;
+
+ public static class IconDescriptor {
+ public URI baseUri;
+ public String[] composition;
Review comment:
Please add a comment describing the meaning of `composition` array.
##########
File path:
java/java.lsp.server/src/org/netbeans/modules/java/lsp/server/explorer/TreeNodeRegistry.java
##########
@@ -40,6 +42,19 @@
CompletionStage<TreeViewProvider> createProvider(String id);
public class ImageDataOrIndex {
+ /**
+ * Base URL of the image, if it could be extracted from the Image
object.
+ */
+ public URI baseURI;
+
+ /**
+ * URLs(?) of additional image constituents.
Review comment:
Here is some javadoc for `composition`. Surprises me there is
`IconDescriptor` and `ImageDataOrIndex`...
##########
File path:
java/java.lsp.server/src/org/netbeans/modules/java/lsp/server/explorer/TreeItem.java
##########
@@ -42,6 +42,7 @@
// rendered less prominent. When true, it is derived from resourceUri
public String description;
// ?: string | Uri | {dark: string | Uri, light: string | Uri} | ThemeIcon
+ public IconDescriptor iconDescriptor;
Review comment:
Is the comment on line 45 supposed to apply to `IconDescriptor`? It
doesn't seem to match.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
