entlicher commented on pull request #3427: URL: https://github.com/apache/netbeans/pull/3427#issuecomment-1008358723
> `getSourceFileURI` should probably return an actual URI. This forces everything in this class to use URIs instead of Strings and this won't happen again easily. > > `fullpath.toUri().toString()` might look like an inefficiency for some which could reintroduce the bug again. Well, we implement LSP and we need a String at the end. There's no URI in org.eclipse.lsp4j.debug.Source. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
