lkishalmi commented on pull request #3480: URL: https://github.com/apache/netbeans/pull/3480#issuecomment-1017800577
@sdedic thanks for the detailed summary. It seems it would be enough to adjust the wizard operations and some of the loading work in the new paradigm. I still think, that some refactoring reorganization of the code needs to be done. NbGradleProjectImpl is leaking different GradleProjects on too many methods with too many parameters. What is on my mind is to encapsulate these parameters and the loading code into a separate object to make the things clearer. @neilcsmith-net With that change I'm rebased this PR on delivery branch as this would only fix the template operations and the possible stack overflow in AbstractProjectLoader -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
