sdedic opened a new pull request #3541:
URL: https://github.com/apache/netbeans/pull/3541


   I found the cause for #3526  : the implementation was changed in 
[bd4fd0e](https://github.com/apache/netbeans/commit/bd4fd0e4f6f323c458869ca4d77f6efd8b24f012#diff-d217c6a1644bb679cd1327c9fb77e539735b405f6874f62760a7522bda248172R54)
 -- the delegated-to implementation behaves differently depending on if the 
configured directories exist.
   
   I fixed the `getSourceRoots` impl to always return URIs that end with "/". I 
found out that there's an API method `FileUtilities.convertStringToUri` which 
behaves this way which is not sometimes (always ?) preferred. As it is just 
before RCs, I don't want to add another API method, so I left a note in the 
code instead & will keep the issue for myself to finish after NB13 release is 
done to avoid different content in `delivery` and `master`.
   
   - Maybe I can just create a new PR with a proper API change for ` master`, 
if merging from/to `delivery` is not an issue -- @neilcsmith-net  ?
   - @dbalek  is it OK for LSP operations ?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

Reply via email to