mbien commented on pull request #3645: URL: https://github.com/apache/netbeans/pull/3645#issuecomment-1048378242
> My usual approach is to avoid touching big pieces of old code until it actually gets in the way of something new. There's always the danger of breaking something unintentionally. In projects like netbeans (old, big code base with the intention to stick around, while not very concerned about having to backport bugfixes) I try to do both. Fix the issue, but also leave the general area of the fix a bit cleaner than it was before if there is such opportunity. Cleanups should be its own commit if possible to make reviews easier and not influence git bisects - but i think its ok to have it in the same PR, right after the fix. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
