matthiasblaesing commented on a change in pull request #3642:
URL: https://github.com/apache/netbeans/pull/3642#discussion_r813090270
##########
File path: java/java.api.common/build.xml
##########
@@ -21,5 +21,21 @@
-->
<project basedir="." default="build" name="java/java.api.common">
<import file="../../nbbuild/templates/projectized.xml"/>
+
+ <target name="generate-antlr-parser" description="Regenerate the CSS
parser from the ANTLR3 grammar">
Review comment:
Thank you for the review. I actually thought about this (and planned to
remove the generated java files from the repository), but the generated code is
not reproducible.
Antlr3 injects the generation time and paths into the files and at least
from a quick look, this could not be overriden. Debian carries a patch the also
changes the source, so that reproducible datastructures are used
(https://sources.debian.org/patches/antlr3/3.5.2-9/05-reproducible-parsers.patch/).
So the code will change on each build and from my perspective this does not
scale. In this case IMHO it is better to keep the generated parsers and
regenerate them when needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
