matthiasblaesing commented on a change in pull request #3646:
URL: https://github.com/apache/netbeans/pull/3646#discussion_r814160927
##########
File path: java/j2ee.eclipselink/nbproject/project.xml
##########
@@ -26,29 +26,126 @@
<code-name-base>org.netbeans.modules.j2ee.eclipselink</code-name-base>
<module-dependencies/>
<public-packages>
- <subpackages>org.eclipse</subpackages>
+ <subpackages>org.eclipse.persistence</subpackages>
Review comment:
If you want to expose only the package and not the package where it is a
prefix of, `package` is the right element. Your assessment is right, internal
should not be exposed.
The sigtest fails from my interpretation because classes are missing:
https://app.travis-ci.com/github/apache/netbeans/jobs/560459188#L12806-L12808
This smells like these:
https://search.maven.org/artifact/jakarta.resource/jakarta.resource-api/1.7.4/jar
https://search.maven.org/artifact/jakarta.transaction/jakarta.transaction-api/1.3.3/jar
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
