JaroslavTulach commented on a change in pull request #3674:
URL: https://github.com/apache/netbeans/pull/3674#discussion_r815311280
##########
File path:
enterprise/cloud.oracle/src/org/netbeans/modules/cloud/oracle/actions/OpenServiceConsoleAction.java
##########
@@ -16,33 +16,33 @@
* specific language governing permissions and limitations
* under the License.
*/
-package org.netbeans.modules.cloud.oracle;
+package org.netbeans.modules.cloud.oracle.actions;
import org.netbeans.modules.cloud.oracle.items.DatabaseItem;
-import java.awt.Desktop;
import java.awt.event.ActionEvent;
import java.awt.event.ActionListener;
-import java.io.IOException;
-import java.net.URI;
-import java.net.URISyntaxException;
+import java.net.MalformedURLException;
+import java.net.URL;
import org.openide.awt.ActionID;
import org.openide.awt.ActionReference;
import org.openide.awt.ActionReferences;
import org.openide.awt.ActionRegistration;
+import org.openide.awt.HtmlBrowser.URLDisplayer;
import org.openide.util.Exceptions;
import org.openide.util.NbBundle.Messages;
@ActionID(
category = "Tools",
- id = "org.netbeans.modules.cloud.oracle.OpenServiceConsoleAction"
+ id =
"org.netbeans.modules.cloud.oracle.actions.OpenServiceConsoleAction"
Review comment:
Changing ID of already published action will make all the previous
usages invalid. The reason for introducing `id` attribute and not using an ID
derived from name of the class what exactly this: refactoring moves shall not
break other modules referencing the action.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
