neilcsmith-net edited a comment on pull request #3744: URL: https://github.com/apache/netbeans/pull/3744#issuecomment-1065171058
It wasn't an argument for or against `install-jdk.sh`. It was an argument for picking _one_ way to do this. We're already using it - eg. https://github.com/apache/netbeans/blob/master/.travis.yml#L445 > I wanted to avoid modifying the behavior of the Travis scripts. For example by accidentally switching to JDK11 for testing. Understand argument for known JDK. But don't see why there's more chance of accidentally switching from using `JAVA_HOME` with the already installed JDKs vs one downloaded. Either way, had wondered merit of running `ant -diagnostics` on each switch of JDK for sanity checking? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
