matthiasblaesing commented on pull request #3742: URL: https://github.com/apache/netbeans/pull/3742#issuecomment-1065415288
The change in `VanillaPartialReparser` is unnessary, as the code path can only be hit if assertions are enabled (with assertions disabled (i.e. a non dev build), 332 is not hit and a stays `false`): https://github.com/apache/netbeans/blob/22368c42d1041f7b536c1cac576f4cd010a1a672/java/java.source.base/src/org/netbeans/modules/java/source/parsing/VanillaPartialReparser.java#L331-L333 IMHO then it is correct, that the problem is reported. I don't think these changes address the problem reported. The reported dump files are created by `VerifyPartialReparse`: https://github.com/apache/netbeans/blob/22368c42d1041f7b536c1cac576f4cd010a1a672/java/java.source.base/src/org/netbeans/modules/java/source/parsing/VanillaPartialReparser.java#L512-L558 line 534 creates the diff between the trees. As dumping is already partially protected it might be an option to tie the activation of `VerifyPartialReparse` to assertions: https://github.com/apache/netbeans/blob/22368c42d1041f7b536c1cac576f4cd010a1a672/java/java.source.base/src/org/netbeans/modules/java/source/parsing/VanillaPartialReparser.java#L606-L614 ```java @MimeRegistration(service=TaskFactory.class, mimeType="text/x-java") public static final class FactoryImpl extends TaskFactory { @Override public Collection<? extends SchedulerTask> create(Snapshot snapshot) { boolean enableVerifier = false; assert enableVerifier = true; if (enableVerifier) { return Collections.singletonList(new VerifyPartialReparse()); } } } ``` @jlahoda what do you think about this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
