mcdonnell-john edited a comment on pull request #3699: URL: https://github.com/apache/netbeans/pull/3699#issuecomment-1063174456
Just seeing this now... > Thanks @mcdonnell-john Looks like my concerns about notarization issues are starting to realise! 😄 > Yeah :) > There's no need for the GitHub issue ( #3697 ) - PR fine - linking in so we have the log. > I'll close the issue then, wasnt sure if I needed an issue to link to a PR or not. > Do these changes get notarization to pass? I'm surprised it's not erroring with other libs in jars - eg. JNA. Also, including x86 libs and/or ~lack of hardened runtime being allowed through~? This seems like it still wouldn't meet the "requirements" at https://developer.apple.com/documentation/security/notarizing_macos_software_before_distribution ?? > Yes, they are passing notarization, however its worth pointing out the notarization logs to call out a warning on other .pkg files, so I might need to raise another ticket with Apple as the notarization log doesn't provide any feedback on what those warnings are about. I'm not sure about the entitlements, I can take a further look before doing any release(just incase) > Base branch is master. Can you build from NetBeans 13 release using master? Or do we need to merge to delivery and then release branch? > If I go with the approach in the email thread I will keep this against master as I don't think we need to rebuild 13, I will generate the new distpreparations zip myself. > EDIT: Sorry, just noticed you do have `--options runtime`, but does it need an entitlements file if we do this? Nothing came up when I added this in, however based on what I've learned to date that means nothing 😄 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
