mbien commented on pull request #3764: URL: https://github.com/apache/netbeans/pull/3764#issuecomment-1065993291
> Looks sane to me, though I would make more sense just to return `defaultAnswer` straight away. That way we would get consistent results from this and not rely on runtime behavior. I have no strong feelings either way, just a thought. the only usage of this method is a code generator here: https://github.com/apache/netbeans/blob/4ae01ea70f4530443343beee3292e880a74099bd/ide/schema2beans/src/org/netbeans/modules/schema2beansdev/JavaBeanClass.java#L4421 this is called at buildtime. It might be also used at runtime somewhere - I haven't investigated further, my main intention was to make NB buildable on JDK 17 without changing the behavior too much. This can be still improved later if needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
