lkishalmi opened a new pull request #3787: URL: https://github.com/apache/netbeans/pull/3787
@sdedic this is an attempt to tame the Gradle project loading methods and calls. My motivation was, that I started to get lost in the calls when a Gradle project, loaded re-loaded. What I'm trying here is to move the options of the different kind of re-loads into a separate class as [GradleLoadOptions](extide/gradle/src/org/netbeans/modules/gradle/loaders/GradleLoadOptions.java) so the code can be more descriptive, and the usage of certain load flags could be more easily tracked. I could be completely wrong with this PR and my approach could be wrong as well. Your feedback is essential. I've tried not to break things, though made a few not compatible changes. loadedProjectSerial and currentSerial in NBGradleProjectImpl were moved to a new sequence field to GradleProject, so dumpProject() cannot set the loadedProjectSerial to zero. Tests seems to be fine, save NbGradleProjectImpl.testEventsProcessedBeforeCompletion() which hangs in infinite wait. Unfortunately I could not crack what that test really does, so I need some help there. There are some unused code mentioning GradleLoadContext that shall be ignored. I have purposefully not changed the javadoc on the load methods yet, so the former parameters can be looked up while replacing the calls with GradleLoadOptions arguments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
