JaroslavTulach commented on a change in pull request #44:
URL: https://github.com/apache/netbeans-html4j/pull/44#discussion_r833157599



##########
File path: ko4j/src/main/java/org/netbeans/html/ko4j/Knockout.java
##########
@@ -315,8 +307,25 @@ function write(val) {
             };
             var cmpt = ko['computed'](bnd);
             cmpt['valueHasMutated'] = function(val) {
-              if (arguments.length === 1) activeGetter = function() { return 
val; };
-              trigger(val);
+              if (arguments.length === 1) {
+                value = val;
+                trigger(val);
+              } else {
+                var self = ret['ko4j'];
+                if (self) {
+                  var futureValue = 
[email protected]::getValue(I)(index);
+                  Promise.resolve(futureValue).then(function(val, e) {

Review comment:
       The whole `ko4j` bindings are now ready for `wait4java=false`, however, 
that means various updates may happen asynchronously. To get ready for that I 
had to modify the _Test Compatibility Kit_ to work in _quantums_: 
https://github.com/apache/netbeans-html4j/commit/1e398f86e740ba4aebef9457e0bea2dadf651b56




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

Reply via email to