jlahoda commented on a change in pull request #3386:
URL: https://github.com/apache/netbeans/pull/3386#discussion_r835739968
##########
File path: platform/core.execution/src/org/netbeans/core/execution/Install.java
##########
@@ -88,7 +89,7 @@
private static final Logger LOG =
Logger.getLogger(Install.class.getName());
public @Override void run() {
- TopSecurityManager.register(SecMan.DEFAULT);
+ TrackingHooks.register(SecMan.DEFAULT, 100, TrackingHooks.HOOK_EXIT,
TrackingHooks.HOOK_NEW_AWT_WINDOW);
Review comment:
Seems fairly complex, as there are uses that actively use the
pre-existing register/unregister mechanism in `TopSecurityManager`:
https://github.com/apache/netbeans/blob/ebb8086be371e8b3ec502a10cf9674c1bfb49dca/platform/core.execution/src/org/netbeans/core/execution/Install.java#L91
https://github.com/apache/netbeans/blob/ebb8086be371e8b3ec502a10cf9674c1bfb49dca/platform/core.execution/src/org/netbeans/core/execution/Install.java#L100
It is not clear to me how to replace that with a Lookup-based registration.
But if you can provide a patch to resolve all existing uses of
`TopSecurityManager.register/unregister`, then we can switch to a Lookup-based
registration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
