mbien commented on PR #3953: URL: https://github.com/apache/netbeans/pull/3953#issuecomment-1100245895
> Looks good, at least for a short term solution. A proper API for this, and linked to nb-javac updates in some way so the increment _can't_ be missed, might be useful in the future? @neilcsmith-net I thought about this a bit. It is essentially a runtime dependency check. Someone gonna have to bump the number no matter where it is taken from. We can't put it into the nb-javac module since the check has to work without it. an assert could potentially check: `assert ((NB_VERSION / 2 + 11) == REQUIRED_JAVAC_VERSION)` which would fail if someone forgets the bump REQUIRED_JAVAC_VERSION in NB 16. However, where do we get `NB_VERSION` from? The release would have a system property for that, but a dev version doesn't. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
