mbien commented on code in PR #3558:
URL: https://github.com/apache/netbeans/pull/3558#discussion_r853605217
##########
apisupport/maven.apisupport/src/org/netbeans/modules/maven/apisupport/MavenNbModuleImpl.java:
##########
@@ -119,13 +119,13 @@ static List<RepositoryInfo> netbeansRepo() {
RepositoryPreferences.getInstance().getRepositoryInfoById(MAVEN_CENTRAL));
}
+ /**
+ * Returns the latest known version of the NetBeans maven plugin.
+ * This method will not wait for the index to be downloaded, it will
return a default value instead.
+ */
public static String getLatestNbmPluginVersion() {
RepositoryQueries.Result<NBVersionInfo> versionsResult =
RepositoryQueries.getVersionsResult(GROUPID_APACHE, NBM_PLUGIN, null);
- if (versionsResult.isPartial()) {
- versionsResult.waitForSkipped();
- }
Review Comment:
did some more manual testing and everything worked fine. I think we could
try to get this in NB 14 (assuming travis is green again, queue is full ATM)
This PR would reduce on-disk storage size by about 800mb for a fresh index
and queries appear to have slightly better performance too when tested side by
side.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
