jtulach opened a new pull request, #4052: URL: https://github.com/apache/netbeans/pull/4052
Continuous work on https://github.com/enso-org/enso/pull/3389 has revealed that [it is not possible to exclude](https://github.com/enso-org/enso/pull/3389/commits/3fd211cf318448a0bb03a67e97c4219b78e4595e) five NetBeans libraries when using sampler module standalone. To address that this PR continues in https://github.com/apache/netbeans/pull/4047: - d66ce57938eea2037648bb7ecc4d5f121476b598 duplicates the tests to check not only the `InternalSampler`, but also existing `CLISampler` - 9f4ec39ed761ce5950a51b370061ed0f85e2aaf2 adds yet another `StandaloneSampler` and its test The test creates own `ClassLoader` and loads just the sampler JAR, without dependencies on other NetBeans modules (so `Lookup` isn't available) and then performs the `AbstractSamplerBase` tests. This guarantees that all three samplers behaves the same. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
