neilcsmith-net commented on code in PR #4045: URL: https://github.com/apache/netbeans/pull/4045#discussion_r861689677
########## java/libs.nbjavacapi/manifest.mf: ########## @@ -2,7 +2,7 @@ Manifest-Version: 1.0 AutoUpdate-Show-In-Client: true OpenIDE-Module: org.netbeans.libs.nbjavacapi OpenIDE-Module-Localizing-Bundle: org/netbeans/modules/nbjavac/api/Bundle.properties -OpenIDE-Module-Specification-Version: 18.0 +OpenIDE-Module-Specification-Version: 18.1 Review Comment: That would be ideal, but checking 8da225d7f7cee699077fa015d5355fe2d03a449a the spec version task always increments the second number even when there are further dots, so I think keeping the major number in sync is about all we can do. Perhaps look at `18.1.1`, `18.1.2` if we really want to have the JDK update in there too?? :shrug: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
