mbien commented on code in PR #4012:
URL: https://github.com/apache/netbeans/pull/4012#discussion_r862967438
##########
java/java.editor/test/unit/src/org/netbeans/modules/editor/java/GoToSupportTest.java:
##########
@@ -1581,7 +1581,10 @@ private static boolean hasRecords() {
}
public void testJavadocSnippetHighlightRecord() throws Exception {
- if (!TreeShims.isJDKVersionRelease18_Or_Above()) {
+ try {
+ SourceVersion.valueOf("RELEASE_18"); //NOI18N
+ } catch (IllegalArgumentException ex) {
+ //OK, no RELEASE_18, skip tests
return;
}
Review Comment:
yep, it should be possible to remove the javac version checks and the
reflective code and change everything to direct calls.
Even if the user uninstalls nb-javac, NB has a runtime dependency check
which will tell the user to run on a specific JDK or install nb-javac again.
You can see it here: https://github.com/apache/netbeans/pull/3953/files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
