ratcashdev commented on PR #3995: URL: https://github.com/apache/netbeans/pull/3995#issuecomment-1117816021
As I see it, the only occasion, where the code is using the 3-arg constructor, is when executing a single test method, and this is not 'sent' or provided to other modules. All other cases (if any) will be using the 2-arg constructor, where there's no issue with the equals. Besides, for a case like `Dummy#test` enclosing type will be `null`. https://github.com/apache/netbeans/pull/3995/files#diff-fa5324f0386490b6cfc96b5331e831a50db1dc5703bc1d7b0f47636f22a43f1aR186 It will only be non-null, if the method is in a class like `Dummy$EmbeddedClass#test`, in which case `enclosingType` will be `EmbeddedClass` (assuming that the name of the file is `Dummy.java`), and then again, this is only done for JAVA/JUnit sources. So I don't have to care about PHP here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
