sdedic commented on PR #4072: URL: https://github.com/apache/netbeans/pull/4072#issuecomment-1118251403
> One question though, you mentioned the tests were failing on JDK 11 prior to this PR. Does CI not run this scenario? This sounds like something we should add. > Yes; tests in https://ci-builds.apache.org/job/Netbeans/view/vscode/job/netbeans-vscode/1061/ fail because of this. The same suite runs with JDK8 (= no module system) routinely. And yes, we should definitely run more testsuites on JDK11 :) but that should be probably a separate task/effort focused just on this. Right now I'd like to fix the vscode master builds at least. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
