lbownik commented on PR #4080: URL: https://github.com/apache/netbeans/pull/4080#issuecomment-1121591830
> I think @vieiro tried to make the point, that this PR is to much noise for to little gain." I do understand the workload issue - I will not propose any solutions to this as I'm new to community and I know too little. " Cosmetic changes by us nothing" My experience tells me otherwise - often small cosmentic changes change the way I see the problem and help me find better solutions in the end. I can make small laser-focused PR's if this helps. ", but take time to review and see where breaks might have been introduced." That's why we have unit tests. If this helps, I can intriduce separate PRs, one for tests cleaning and code cleaning. I would submit code cleaning PR only after test cleaning PR gets merged. "PRs should fix problems, not cosmetics." I've seen this approach in action - it leads to code rot and spaghetti (and bancrupcy in case of commercial software). Sustainable development is all about entropy, there needs to be constant conscious effort to reduce it, otherwise it kills eventually every project. So would smaller PRs which tests first/code second approach work better? I woud also skip final's and this'es. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
