sdedic commented on code in PR #4100:
URL: https://github.com/apache/netbeans/pull/4100#discussion_r869458329
##########
java/java.mx.project/test/unit/src/org/netbeans/modules/java/mx/project/SuiteActionProviderTest.java:
##########
@@ -44,7 +44,7 @@ public static junit.framework.Test suite() {
}
public void testActionsEnabledWithProgress() throws Exception {
- File sdkSibling = findSuite("sdk");
+ File sdkSibling = findSuite("regex");
Review Comment:
OK, regex is fairly small one.
##########
java/java.mx.project/test/unit/src/org/netbeans/modules/java/mx/project/SuiteActionProviderTest.java:
##########
@@ -86,8 +86,9 @@ public void finished(boolean success) {
MockProgress progress = new MockProgress();
Lookup ctx = Lookups.fixed(fo, p, progress);
- assertTrue("Clean is supported",
ap.isActionEnabled(ActionProvider.COMMAND_CLEAN, ctx));
- ap.invokeAction(ActionProvider.COMMAND_CLEAN, ctx);
+ assertTrue("Build is supported",
ap.isActionEnabled(ActionProvider.COMMAND_BUILD, ctx));
+ // Do not run clean action here as it breaks next tests.
+ ap.invokeAction(ActionProvider.COMMAND_BUILD, ctx);
assertTrue("Progress started", progress.started);
progress.finished.await(10, TimeUnit.SECONDS);
Review Comment:
Since `build` may take more time than `clean`, consider to increase the
timeout here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
