mbien commented on code in PR #4105:
URL: https://github.com/apache/netbeans/pull/4105#discussion_r872337654
##########
.travis.yml:
##########
@@ -593,60 +593,6 @@ matrix:
- ant $OPTS -f enterprise/websvc.editor.hints test
- ant $OPTS -f enterprise/websvc.websvcapi test
- ant $OPTS -f enterprise/websvc.wsstackapi test
-
- - name: Test groovy modules on Java 8
- jdk: openjdk8
- env:
- -
BUILD_OPTS="-Dmetabuild.jsonurl=https://raw.githubusercontent.com/apache/netbeans-jenkins-lib/master/meta/netbeansrelease.json
-quiet -Dcluster.config=groovy -Djavac.compilerargs=-nowarn
-Dbuild.compiler.deprecation=false
-Dtest-unit-sys-prop.ignore.random.failures=true"
- -
TEST_OPTS="-Dmetabuild.jsonurl=https://raw.githubusercontent.com/apache/netbeans-jenkins-lib/master/meta/netbeansrelease.json
-Dcluster.config=groovy -Djavac.compilerargs=-nowarn
-Dbuild.compiler.deprecation=false
-Dtest-unit-sys-prop.ignore.random.failures=true"
- before_script:
- - nbbuild/travis/ant.sh $BUILD_OPTS clean
- - nbbuild/travis/ant.sh $BUILD_OPTS build
- script:
- #- ant $TEST_OPTS -f groovy/groovy test
- #- ant $TEST_OPTS -f groovy/groovy.java test
- - ant $TEST_OPTS -f groovy/groovy.editor test
- - ant $TEST_OPTS -f groovy/groovy.gsp test
- #- ant $TEST_OPTS -f groovy/groovy.kit test
- - ant $TEST_OPTS -f groovy/groovy.support test
-
- - name: Test groovy modules on Java 11
- jdk: openjdk8
- env:
- -
BUILD_OPTS="-Dmetabuild.jsonurl=https://raw.githubusercontent.com/apache/netbeans-jenkins-lib/master/meta/netbeansrelease.json
-quiet -Dcluster.config=groovy -Djavac.compilerargs=-nowarn
-Dbuild.compiler.deprecation=false
-Dtest-unit-sys-prop.ignore.random.failures=true"
- -
TEST_OPTS="-Dmetabuild.jsonurl=https://raw.githubusercontent.com/apache/netbeans-jenkins-lib/master/meta/netbeansrelease.json
-Dcluster.config=groovy -Djavac.compilerargs=-nowarn
-Dbuild.compiler.deprecation=false
-Dtest-unit-sys-prop.ignore.random.failures=true"
- before_script:
- - nbbuild/travis/ant.sh $BUILD_OPTS clean
- - nbbuild/travis/ant.sh $BUILD_OPTS build
- - wget
https://raw.githubusercontent.com/sormuras/bach/master/install-jdk.sh
- - export TEST_JDK=`bash install-jdk.sh --feature 11 --license GPL
--emit-java-home --silent | tail -1`
- - export
OPTS="-Dmetabuild.jsonurl=https://raw.githubusercontent.com/apache/netbeans-jenkins-lib/master/meta/netbeansrelease.json
$OPTS -Dtest.nbjdk.home=$TEST_JDK
-Dtest.run.args=--limit-modules=java.base,java.logging,java.xml,java.prefs,java.desktop,java.management,java.instrument,jdk.zipfs,java.scripting,java.naming
-Dtest.bootclasspath.prepend.args=-Dno.netbeans.bootclasspath.prepend.needed=true"
- script:
- #- ant $TEST_OPTS -f groovy/groovy test
- #- ant $TEST_OPTS -f groovy/groovy.java test
- - ant $TEST_OPTS -f groovy/groovy.editor test
- - ant $TEST_OPTS -f groovy/groovy.gsp test
- #- ant $TEST_OPTS -f groovy/groovy.kit test
- - ant $TEST_OPTS -f groovy/groovy.support test
-
- - name: Test groovy modules on Java 17
- jdk: openjdk8
- env:
- -
BUILD_OPTS="-Dmetabuild.jsonurl=https://raw.githubusercontent.com/apache/netbeans-jenkins-lib/master/meta/netbeansrelease.json
-quiet -Dcluster.config=groovy -Djavac.compilerargs=-nowarn
-Dbuild.compiler.deprecation=false
-Dtest-unit-sys-prop.ignore.random.failures=true"
- -
TEST_OPTS="-Dmetabuild.jsonurl=https://raw.githubusercontent.com/apache/netbeans-jenkins-lib/master/meta/netbeansrelease.json
-Dcluster.config=groovy -Djavac.compilerargs=-nowarn
-Dbuild.compiler.deprecation=false
-Dtest-unit-sys-prop.ignore.random.failures=true"
- before_script:
- - nbbuild/travis/ant.sh $BUILD_OPTS clean
- - nbbuild/travis/ant.sh $BUILD_OPTS build
- - wget
https://raw.githubusercontent.com/sormuras/bach/master/install-jdk.sh
- - export TEST_JDK=`bash install-jdk.sh --feature 17 --license GPL
--emit-java-home --silent | tail -1`
- - export
OPTS="-Dmetabuild.jsonurl=https://raw.githubusercontent.com/apache/netbeans-jenkins-lib/master/meta/netbeansrelease.json
$OPTS -Dtest.nbjdk.home=$TEST_JDK
-Dtest.run.args=--limit-modules=java.base,java.logging,java.xml,java.prefs,java.desktop,java.management,java.instrument,jdk.zipfs,java.scripting,java.naming
-Dtest.bootclasspath.prepend.args=-Dno.netbeans.bootclasspath.prepend.needed=true"
- script:
- #- ant $TEST_OPTS -f groovy/groovy test
- #- ant $TEST_OPTS -f groovy/groovy.java test
- - ant $TEST_OPTS -f groovy/groovy.editor test
Review Comment:
can someone explain how the groovy tests actually work?
- what does `OPTS` do? I don't think anything is picking this env var up
- no JMS flags are set, which means this actually can't run on JDK 17 since
it would fail with encapsulation exceptions
- `JAVA_HOME` is in fact correctly set but i can see in the travis log
lines like `[nb-javac] Support for javac --release has been added in Java9
ignoring it` which further indicates that this is running on JDK 8
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
