neilcsmith-net commented on PR #4096:
URL: https://github.com/apache/netbeans/pull/4096#issuecomment-1126891768

   > a clean checkout fails now, as core goals are skipped (in my case 
package). Integration tests are run after package
   
   @matthiasblaesing yes, one of the questions Eric and I have both raised is 
what goal(s) needs to run first, presumably `package` for this to work?
   
   > I would argue, that the current "run single test" action is broken as is 
and needs to be updated to call into test ... Your suggestion breaks working 
test while only giving toy tests the benefit to pretend to work.
   
   For the record, I agree with you here that _if feasible_ we should just call 
`test`, and in fact map all actions to Maven goals rather than plugins. That 
would depend on improving default POM and looking at the properties passed in 
to make this work though.
   
   Also for the record, this isn't _my_ suggestion, but the action mappings 
should at least work in a consistent way (and this one could be made to 
function correctly).
   
   As NB13 and NB14 are both broken here in different ways, it's not so much of 
a regression.  IMO up to @ebarboni whether to update this PR with working 
pre-goals or not merge.  Anything wider should be left for discussion in NB15.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

Reply via email to