mbien opened a new pull request, #4165:
URL: https://github.com/apache/netbeans/pull/4165

    - attempting to open the next completion can cause problems if the
      completion itself is not implemented correctly (infinite completion loops)
    - to mitigate this we can check if the template had a removed
      "completionInvoke" group (defined by the template param with the same 
name)
      so that for example constructor completions still work as expected
   
   
   ```java
   // completion for:
   new HashM
   // would have the template:
   "HashMap<>${cursor completionInvoke}"
   // and would insert
   new HashMap<>
   // and would continue with the next completion for constructors due to the 
removed "completionInvoke" group
   new HashMap<>()
   ```
   
   followup of #2519, #3290
   
   example of a completion which never finishes: #3805
   
   lets see if all tests are green.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

Reply via email to