mbien commented on code in PR #4165:
URL: https://github.com/apache/netbeans/pull/4165#discussion_r890274449
##########
ide/editor.codetemplates/src/org/netbeans/lib/editor/codetemplates/CodeTemplateInsertHandler.java:
##########
@@ -109,7 +109,7 @@ public final class CodeTemplateInsertHandler implements
TextRegionManagerListene
private TextSyncGroup textSyncGroup;
private boolean completionInvoked;
-
+
Review Comment:
usually I am keeping the cleanup separate and arrange it like in this PR:
https://github.com/apache/netbeans/pull/4142/commits
but this is extra work since every time i modify the bugfix commit I have to
resolve merge conflicts in the cleanup commit
So I do that only if I think the PR complexity justifies that.
This PR was fairly small and changes like the one you marked were not even
intended. You can filter them out in the github UI btw. Settings cog -> hide
whitespace
At least I know that someone is inspecting commit by commit and not just via
the "Files Changed" tab so that it is worth the effort :) Thanks for the
feedback.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
