neilcsmith-net commented on PR #4205: URL: https://github.com/apache/netbeans/pull/4205#issuecomment-1149739890
Generally looks good. Can take a better look next week (busy with installers atm) but merge before then if you want to. I was considering looking at a bigger revamp of this UI in NB15. Updating to Disco v2 threw up some quirks and missing info. Possibly also worth comparing with other IDE plugins (eg. https://marketplace.eclipse.org/content/discoeclipse ) and I would say online use at https://foojay.io/download/ (except doesn't work at all for me in Firefox!) A key question might be whether we should only support listing and downloading JDKs that can be registered in the running IDE? Or at least shouldn't register ones that cannot run. Maybe keep advanced as is, but we add a few options on to quick selection (eg. vendor), and possibly move to selection box over slider? The slider ran out of space hence change of min version in NB14! :smile: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
