mbien commented on code in PR #57: URL: https://github.com/apache/netbeans-mavenutils-nbm-maven-plugin/pull/57#discussion_r905369259
########## nb-repository-plugin/pom.xml: ########## @@ -20,68 +20,119 @@ under the License. --> <project xmlns="http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> + <modelVersion>4.0.0</modelVersion> + <parent> <groupId>org.apache.netbeans.utilities</groupId> <artifactId>utilities-parent</artifactId> - <version>2</version> + <version>14.0-SNAPSHOT</version> + <relativePath>../</relativePath> </parent> - <modelVersion>4.0.0</modelVersion> <artifactId>nb-repository-plugin</artifactId> - <version>1.8-SNAPSHOT</version> <packaging>maven-plugin</packaging> <name>Apache NetBeans Maven Utilities - NB Repository Plugin</name> <description>Maven plugin for creating Maven Repository out of a NetBeans installation (and other sources) for consumption by the projects using nbm-maven-plugin. </description> <inceptionYear>2005</inceptionYear> - <url>https://bits.netbeans.org/mavenutilities/nb-repository-plugin</url> - <issueManagement> - <system>jira</system> - <url>https://issues.apache.org/jira/browse/NETBEANSINFRA</url> - </issueManagement> - <prerequisites> - <maven>3.1.1</maven> - </prerequisites> <licenses> <license> <name>Apache License 2</name> <url>http://www.apache.org/licenses/LICENSE-2.0.txt</url> <distribution>repo</distribution> </license> </licenses> - <scm> - <connection>scm:git:https://gitbox.apache.org/repos/asf/netbeans-mavenutils-nb-repository-plugin.git</connection> - <developerConnection>scm:git:https://gitbox.apache.org/repos/asf/netbeans-mavenutils-nb-repository-plugin.git</developerConnection> - <url>https://github.com/apache/netbeans-mavenutils-nb-repository-plugin</url> - <tag>HEAD</tag> - </scm> - <!-- TODO need to override parent version value... I suppose this will eventually end up in mojo parent pom, check regularly --> + <prerequisites> + <maven>3.1.1</maven> + </prerequisites> Review Comment: nit pick: I believe this mechanism is deprecated, `org.apache.maven.plugins:maven-enforcer-plugin` took over that role. with the rule: ```xml <rules> <requireMavenVersion> <version>3.1.1</version> </requireMavenVersion> </rules> ``` see https://issues.apache.org/jira/browse/MNG-5297 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
