neilcsmith-net commented on code in PR #4205:
URL: https://github.com/apache/netbeans/pull/4205#discussion_r908491100
##########
java/java.disco/src/org/netbeans/modules/java/disco/QuickPkgSelection.java:
##########
@@ -57,6 +59,9 @@ public QuickPkgSelection(QuickPanel.QuickSelection quick) {
switch (OS.getOperatingSystem()) {
case WINDOWS:
return ArchiveType.MSI == p.getArchiveType() ||
ArchiveType.EXE == p.getArchiveType();
+ case LINUX:
Review Comment:
Back looking at this. Yes, the shell extraction appears mainly to be about
execution permissions, judging from [this
comment](https://github.com/apache/netbeans/blob/master/java/java.disco/src/org/netbeans/modules/java/disco/archive/JDKCommonsUnzip.java#L32).
That can't work as it misses out `jspawnhelper` at least. I'm working on
porting the extraction and detection solution from NBPackage.
Also a Linux user, and don't see the utility for installing the JDK here.
OTOH, I do like my NetBeans as a DEB! :wink:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
