mbien commented on code in PR #4293:
URL: https://github.com/apache/netbeans/pull/4293#discussion_r909167108
##########
java/java.source/src/org/netbeans/modules/java/ui/Icons.java:
##########
@@ -95,8 +95,8 @@ public static ImageIcon getElementIcon( ElementKind
elementKind, Collection<Modi
icon = ImageUtilities.loadImageIcon(ICON_BASE + "record" +
PNG_EXTENSION, false);
break;
}
- if (elementKind.name().equals("STATE_COMPONENT")) {
- icon = ImageUtilities.loadImageIcon(ICON_BASE +
"stateComponent" + PNG_EXTENSION, false);
+ if (elementKind.name().equals("RECORD_COMPONENT")) {
+ icon = ImageUtilities.loadImageIcon(ICON_BASE +
"recordComponent" + PNG_EXTENSION, false);
break;
}
Review Comment:
nitpick: I think we could use enums here too and add it to the switch,
instead of the if-else String based workaround.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
