matthiasblaesing commented on code in PR #4233:
URL: https://github.com/apache/netbeans/pull/4233#discussion_r911412141
##########
webcommon/web.inspect/src/org/netbeans/modules/web/inspect/ui/CssStylesPanelProviderImpl.java:
##########
@@ -139,7 +139,6 @@ private void initNoStylesLabel() {
noStylesLabel.setHorizontalAlignment(SwingConstants.CENTER);
noStylesLabel.setVerticalAlignment(SwingConstants.CENTER);
noStylesLabel.setEnabled(false);
- noStylesLabel.setBackground(new
BeanTreeView().getViewport().getView().getBackground());
Review Comment:
I tested this on current master - the original code works and is not broken.
I admit, that it is questionable, but it works ;-)
From my perspective it would be good to either guard this with a try-catch
or with a null check, with a comment, that the null case happens in test
variant. (comment matches all cases)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
